[turbofan] Output file for C1 visualizer.

[turbofan] Output schedule, instructions and register allocator in C1 visualizer format when --turbo-trace is specified.

BUG=
R=bmeurer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24583

[Jarin, 2014-10-11 19:59:34]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org, mstarzinger@chromium.org

[Jarin, 2014-10-11 20:00:16]

Could you take a look, please?

[Benedikt Meurer, 2014-10-13 04:02:12]

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:94: FILE* turbo_cfg_file = base::OS::FOpen("turbo.cfg",
"a+");
Please use std::ofstream here.

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:146: FILE* turbo_cfg_file =
base::OS::FOpen("turbo.cfg", "a+");
Please use std::ofstream here.

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:155: FILE* turbo_cfg_file =
base::OS::FOpen("turbo.cfg", "a+");
Please use std::ofstream here.

https://codereview.chromium.org/637313002/diff/70001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/637313002/diff/70001/src/isolate.cc#newcode1935
src/isolate.cc:1935: FILE* turbo_cfg_file = base::OS::FOpen("turbo.cfg", "w+");
Please use std::ofstream here.

[Jarin, 2014-10-13 07:35:55]

All done.

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:94: FILE* turbo_cfg_file = base::OS::FOpen("turbo.cfg",
"a+");
On 2014/10/13 04:02:12, Benedikt Meurer wrote:
> Please use std::ofstream here.

Done.

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:146: FILE* turbo_cfg_file =
base::OS::FOpen("turbo.cfg", "a+");
On 2014/10/13 04:02:12, Benedikt Meurer wrote:
> Please use std::ofstream here.

Done.

https://codereview.chromium.org/637313002/diff/70001/src/compiler/pipeline.cc...
src/compiler/pipeline.cc:155: FILE* turbo_cfg_file =
base::OS::FOpen("turbo.cfg", "a+");
On 2014/10/13 04:02:12, Benedikt Meurer wrote:
> Please use std::ofstream here.

Done.

https://codereview.chromium.org/637313002/diff/70001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/637313002/diff/70001/src/isolate.cc#newcode1935
src/isolate.cc:1935: FILE* turbo_cfg_file = base::OS::FOpen("turbo.cfg", "w+");
On 2014/10/13 04:02:12, Benedikt Meurer wrote:
> Please use std::ofstream here.

Done.

[Vyacheslav Egorov (Google), 2014-10-13 07:42:09]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2014-10-13 07:42:11]

DBC

https://codereview.chromium.org/637313002/diff/150001/src/compiler/graph-visu...
File src/compiler/graph-visualizer.cc (right):

https://codereview.chromium.org/637313002/diff/150001/src/compiler/graph-visu...
src/compiler/graph-visualizer.cc:638: os_ << " <|@\n";
could you also print source position here whenever it is available like 
HTracer::Trace in hydrogen.cc does?

https://codereview.chromium.org/637313002/diff/150001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/637313002/diff/150001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:95: std::ofstream turbo_cfg_stream("turbo.cfg",
consider mangling the name with PID so it works from multiprocess application
like Chrome

[Jarin, 2014-10-13 14:00:26]

Added source positions and process-unique file name.

[Jarin, 2014-10-14 08:17:30]

On 2014/10/13 14:00:26, jarin wrote:
> Added source positions and process-unique file name.

ping.

[Benedikt Meurer, 2014-10-14 08:23:34]

lgtm

[Jarin, 2014-10-14 08:43:51]

Committed patchset #6 (id:490001) manually as 24583 (presubmit successful).