Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 637303002: Don't enable WPO on Win64 and require Server 2003 / x64 for win64 (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Don't enable WPO on Win64 and require Server 2003 / x64 for win64 WPO was only enabled to work around an issue with the Isolate's static initializer which no longer exists. Requiring XP on Win64 doesn't make sense. BUG=421363 R=machenbach@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=24457

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M build/standalone.gypi View 1 2 chunks +14 lines, -1 line 0 comments Download
M build/toolchain.gypi View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-08 09:01:10 UTC) #1
Michael Achenbach
LGTM! Thanks!
6 years, 2 months ago (2014-10-08 09:06:37 UTC) #2
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-08 09:10:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as 24457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698