Issue 6373002: URLRequest::PrepareToRestart() call job_->Kill() and OrphanJob()....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6373002: URLRequest::PrepareToRestart() call job_->Kill() and OrphanJob().... (Closed)

Created:
9 years, 11 months ago by Takashi Toyoshima (Google)

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

URLRequest::PrepareToRestart() call job_->Kill() and OrphanJob(). But OrphanJob() call job_->Kill() internally, so first Kill() call in PrepareToRestart() is not needed. This changelist remove the duplicated Kill() call. BUG=chromium:69937 TEST=pass net_unittests.

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	net/url_request/url_request.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima (Google)

This is a trivial one line patch. Could you review and commit it?

9 years, 11 months ago (2011-01-18 11:10:43 UTC) #1

LGTM.

(I'll commit it).

Expand Messages | Collapse Messages