Correct style ranges on text eliding instead of clearing them

Correct style ranges on text eliding instead of clearing them

BUG=416798
Committed: https://crrev.com/4757aae11843c5fa7891cda80653f51543d2a26d
Cr-Commit-Position: refs/heads/master@{#299865}

[Tomasz Moniuszko, 2014-10-08 08:33:34]

tmoniuszko@opera.com changed reviewers:
+ msw@chromium.org

[Tomasz Moniuszko, 2014-10-08 08:42:22]

This patch fixes regression after https://codereview.chromium.org/371413002/.
Style ranges are corrected (and not cleared) when text is elided.

[msw, 2014-10-08 18:09:37]

Can you also add a unit test for this?

https://codereview.chromium.org/637293002/diff/1/ui/gfx/render_text.h
File ui/gfx/render_text.h (right):

https://codereview.chromium.org/637293002/diff/1/ui/gfx/render_text.h#newcode591
ui/gfx/render_text.h:591: void SetText(const base::string16& text, bool
clear_styles);
The flag doesn't seem worthwhile, just make the existing SetText() fixup ranged
styles. RenderText users can call Set[Style|Color] separately as needed.

[Tomasz Moniuszko, 2014-10-15 11:52:25]

Solution from Patch Set 1 was wrong. IsValidCursorIndex() needs a valid text
layout. We should assume that current layout is invalid and don't call
IsValidCursorIndex() from SetText() even if needs_layout_==false because
layout_text_ is updated at the end of SetText() and layout is reset.

In Patch Set 2 I moved style correcting code directly to Elide() method.
EnsureLayout() can be safely called here on the copy of RenderText so it's also
safe to call IsValidCursorIndex().

[msw, 2014-10-15 19:14:22]

lgtm

[Tomasz Moniuszko, 2014-10-16 06:52:49]

The CQ bit was checked by tmoniuszko@opera.com

[commit-bot: I haz the power, 2014-10-16 06:53:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637293002/20001

[commit-bot: I haz the power, 2014-10-16 07:37:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 07:38:46]

Patchset 2 (id:??) landed as
https://crrev.com/4757aae11843c5fa7891cda80653f51543d2a26d
Cr-Commit-Position: refs/heads/master@{#299865}