Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637283010: Return early from TextAutosizer::updatePageInfo for remote main frame. (Closed)

Created:
6 years, 2 months ago by nasko
Modified:
6 years, 2 months ago
Reviewers:
dcheng
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, site-isolation-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Return early from TextAutosizer::updatePageInfo for remote main frame. BUG=399775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184308

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revert to using deprecatedLocalMainFrame() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/core/rendering/TextAutosizer.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nasko
Hey Daniel, Can you review this CL for me? Thanks! Nasko
6 years, 2 months ago (2014-10-23 21:46:55 UTC) #2
dcheng
https://codereview.chromium.org/637283010/diff/1/Source/core/rendering/TextAutosizer.cpp File Source/core/rendering/TextAutosizer.cpp (right): https://codereview.chromium.org/637283010/diff/1/Source/core/rendering/TextAutosizer.cpp#newcode518 Source/core/rendering/TextAutosizer.cpp:518: LocalFrame* mainFrame = toLocalFrame(frame); I would probably still use ...
6 years, 2 months ago (2014-10-23 21:48:17 UTC) #3
nasko
https://codereview.chromium.org/637283010/diff/1/Source/core/rendering/TextAutosizer.cpp File Source/core/rendering/TextAutosizer.cpp (right): https://codereview.chromium.org/637283010/diff/1/Source/core/rendering/TextAutosizer.cpp#newcode518 Source/core/rendering/TextAutosizer.cpp:518: LocalFrame* mainFrame = toLocalFrame(frame); On 2014/10/23 21:48:17, dcheng wrote: ...
6 years, 2 months ago (2014-10-23 21:50:44 UTC) #4
dcheng
lgtm
6 years, 2 months ago (2014-10-23 21:52:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637283010/20001
6 years, 2 months ago (2014-10-23 22:00:02 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:02:23 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184308

Powered by Google App Engine
This is Rietveld 408576698