Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 637283009: Fix imagemagnifier GM quality and speed. (Closed)

Created:
6 years, 2 months ago by Stephen White
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix imagemagnifier GM quality and speed. The imagemagnifier GM was applying the filter both to a saveLayer() restore() around the whole scene, as well as to each individual text draw. Applying the filter only in the saveLayer() makes it run ~20x faster on my Linux box, and the quality is improved as well (since the primitives are not double-filtered). BUG=skia: Committed: https://skia.googlesource.com/skia/+/cbf6b6ecd5edca74aa9f78ea5b9a73fb955b8654

Patch Set 1 #

Patch Set 2 : Add code review link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gm/imagemagnifier.cpp View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Stephen White
Brian: PTAL. Thanks!
6 years, 2 months ago (2014-10-23 21:21:54 UTC) #2
bsalomon
On 2014/10/23 21:21:54, Stephen White wrote: > Brian: PTAL. Thanks! geez, lgtm.
6 years, 2 months ago (2014-10-23 21:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637283009/20001
6 years, 2 months ago (2014-10-23 21:52:02 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 22:00:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as cbf6b6ecd5edca74aa9f78ea5b9a73fb955b8654

Powered by Google App Engine
This is Rietveld 408576698