Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 637283003: Remove BrowserVersion.java. (Closed)

Created:
6 years, 2 months ago by newt (away)
Modified:
6 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove BrowserVersion.java. BrowserVersion's functionality has been supplanted by ChromeVersionInfo. Committed: https://crrev.com/37c90293fcce187723167ca9cda5046e4b7a4e54 Cr-Commit-Position: refs/heads/master@{#299430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
6 years, 2 months ago (2014-10-13 23:09:02 UTC) #2
Yaron
lgtm assuming downstream was already updated
6 years, 2 months ago (2014-10-14 03:36:22 UTC) #3
newt (away)
On 2014/10/14 03:36:22, Yaron wrote: > lgtm assuming downstream was already updated It was indeed.
6 years, 2 months ago (2014-10-14 03:43:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637283003/1
6 years, 2 months ago (2014-10-14 03:44:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 04:24:52 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 04:26:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37c90293fcce187723167ca9cda5046e4b7a4e54
Cr-Commit-Position: refs/heads/master@{#299430}

Powered by Google App Engine
This is Rietveld 408576698