Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 637273003: Corrected insertion point style recalc. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Corrected insertion point style recalc. When crossing an insertion point boundary from style recalc, we mark the distributed nodes for subtree style recalc. The reason is that the distributed nodes will have their style recalculated in the context of where they are distributed from. In the case below, changing class=a on content will affect the style of class=b. The invalidation starts on class=a and will not reach class=b in the invalidation traversal. The bug was that InsertionPoint::willRecalcStyle had an early return if the parent style change was at least an Inherit, but that is not the case if the class change does not affect anything at, or above, the insertion point, like in the case below. <div> <:shadow-root> <style>.a::content .b { ... }</style> <content class="a"></content> </:shadow-root> <div class="b"></div> </div> R=esprehn@chromium.org,chrishtr@chromium.org BUG=423293 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
A LayoutTests/fast/dom/shadow/content-pseudo-element-dynamic-class.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-dynamic-class-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rune
6 years, 2 months ago (2014-10-16 10:58:13 UTC) #1
chrishtr
lgtm
6 years, 2 months ago (2014-10-16 21:31:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637273003/1
6 years, 2 months ago (2014-10-16 21:32:15 UTC) #4
esprehn
lgtm
6 years, 2 months ago (2014-10-16 21:32:36 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 23:39:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183844

Powered by Google App Engine
This is Rietveld 408576698