Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637263004: fix some bit-rot in the ios port of sampleapp (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
jvanverth1, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix some bit-rot in the ios port of sampleapp BUG=skia: Committed: https://skia.googlesource.com/skia/+/f0b1710bdb0c1a434228b5354d948fec696316ac

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : address comments from #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -30 lines) Patch
M experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M experimental/iOSSampleApp/SkSampleUIView.mm View 1 2 3 chunks +13 lines, -30 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
reed1
compiles, but haven't tried to run this
6 years, 2 months ago (2014-10-20 14:22:11 UTC) #2
jvanverth1
On 2014/10/20 14:22:11, reed1 wrote: > compiles, but haven't tried to run this Works for ...
6 years, 2 months ago (2014-10-20 15:03:05 UTC) #3
jvanverth1
No really, comments: https://codereview.chromium.org/637263004/diff/1/experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm File experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm (right): https://codereview.chromium.org/637263004/diff/1/experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm#newcode107 experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm:107: /* Probably should explain why this ...
6 years, 2 months ago (2014-10-20 15:03:22 UTC) #4
caryclark
lgtm
6 years, 2 months ago (2014-10-20 17:42:35 UTC) #5
reed1
https://codereview.chromium.org/637263004/diff/1/experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm File experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm (right): https://codereview.chromium.org/637263004/diff/1/experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm#newcode107 experimental/iOSSampleApp/Shared/SkUIDetailViewController.mm:107: /* On 2014/10/20 15:03:22, jvanverth1 wrote: > Probably should ...
6 years, 2 months ago (2014-10-22 19:56:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637263004/40001
6 years, 2 months ago (2014-10-22 19:57:21 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 20:06:05 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as f0b1710bdb0c1a434228b5354d948fec696316ac

Powered by Google App Engine
This is Rietveld 408576698