CcTest::isolate_used_ is used from multiple threads, make it atomic

test/cctest/cctest.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 99 matching lines @@
   void Run();
   static CcTest* last() { return last_; }
   CcTest* prev() { return prev_; }
   const char* file() { return file_; }
   const char* name() { return name_; }
   const char* dependency() { return dependency_; }
   bool enabled() { return enabled_; }
 
   static v8::Isolate* isolate() {
     CHECK(isolate_ != NULL);
-    isolate_used_ = true;
+    v8::base::NoBarrier_Store(&isolate_used_, 1);
     return isolate_;
   }
 
   static i::Isolate* InitIsolateOnce() {
     if (!initialize_called_) InitializeVM();
     return i_isolate();
   }
 
   static i::Isolate* i_isolate() {
     return reinterpret_cast<i::Isolate*>(isolate());
@@ skipping 11 matching lines @@
     return InitIsolateOnce()->random_number_generator();
   }
 
   static v8::Local<v8::Object> global() {
     return isolate()->GetCurrentContext()->Global();
   }
 
   // TODO(dcarney): Remove.
   // This must be called first in a test.
   static void InitializeVM() {
-    CHECK(!isolate_used_);
+    CHECK(!v8::base::NoBarrier_Load(&isolate_used_));
     CHECK(!initialize_called_);
     initialize_called_ = true;
     v8::HandleScope handle_scope(CcTest::isolate());
     v8::Context::New(CcTest::isolate())->Enter();
   }
 
   // Only for UNINITIALIZED_TESTs
   static void DisableAutomaticDispose();
 
   // Helper function to configure a context.
@@ skipping 11 matching lines @@
   TestFunction* callback_;
   const char* file_;
   const char* name_;
   const char* dependency_;
   bool enabled_;
   bool initialize_;
   CcTest* prev_;
   static CcTest* last_;
   static v8::Isolate* isolate_;
   static bool initialize_called_;
-  static bool isolate_used_;
+  static v8::base::Atomic32 isolate_used_;
 };
 
 // Switches between all the Api tests using the threading support.
 // In order to get a surprising but repeatable pattern of thread
 // switching it has extra semaphores to control the order in which
 // the tests alternate, not relying solely on the big V8 lock.
 //
 // A test is augmented with calls to ApiTestFuzzer::Fuzz() in its
 // callbacks.  This will have no effect when we are not running the
 // thread fuzzing test.  In the thread fuzzing test it will
@@ skipping 368 matching lines @@
   HandleAndZoneScope() : main_zone_(main_isolate()) {}
 
   // Prefixing the below with main_ reduces a lot of naming clashes.
   i::Zone* main_zone() { return &main_zone_; }
 
  private:
   i::Zone main_zone_;
 };
 
 #endif  // ifndef CCTEST_H_