src/objects.cc - Issue 637253004: Use smi zero instead of undefine_value to zap dead weak cells.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 637253004: Use smi zero instead of undefine_value to zap dead weak cells. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index b95787fe16df3f97202c6d716c5e32c33cf6bd45..9c1830de4de59222e390e27ce473dd4ace5f6ddf 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -9840,7 +9840,7 @@ Handle<JSObject> Script::GetWrapper(Handle<Script> script) {

Isolate* isolate = script->GetIsolate();

if (!script->wrapper()->IsUndefined()) {

Handle<WeakCell> cell(WeakCell::cast(script->wrapper()));

- if (!cell->value()->IsUndefined()) {

+ if (!cell->cleared()) {

// Return a handle for the existing script wrapper from the cache.

return handle(JSObject::cast(cell->value()));

}

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »