content/browser/service_worker/service_worker_context_request_handler_unittest.cc - Issue 637243003: Service Worker: Obey content settings when deciding to control a page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

Issue 637243003: Service Worker: Obey content settings when deciding to control a page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content

Patch Set: explicit, and better log Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_request_handler.cc ('k') | content/browser/service_worker/service_worker_controllee_request_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

index 24243a7f9e184ea57a8aae3417cd120a40863169..9032353ba84e33238ff369c46f65e4a27a161cf2 100644

--- a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

@@ -97,7 +97,7 @@ TEST_F(ServiceWorkerContextRequestHandlerTest, UpdateBefore24Hours) {

base::WeakPtr<storage::BlobStorageContext>(),

RESOURCE_TYPE_SERVICE_WORKER));

scoped_refptr<net::URLRequestJob> job =

- handler->MaybeCreateJob(request.get(), NULL);

+ handler->MaybeCreateJob(request.get(), NULL, NULL);

ASSERT_TRUE(job.get());

ServiceWorkerWriteToCacheJob* sw_job =

static_cast<ServiceWorkerWriteToCacheJob*>(job.get());

@@ -128,7 +128,7 @@ TEST_F(ServiceWorkerContextRequestHandlerTest, UpdateAfter24Hours) {