Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: components/copresence/mediums/audio/audio_recorder_unittest.cc

Issue 637223011: Redesign the copresence audio handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/copresence/mediums/audio/audio_recorder_impl.cc ('k') | components/copresence/proto/enums.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/copresence/mediums/audio/audio_recorder_unittest.cc
diff --git a/components/copresence/mediums/audio/audio_recorder_unittest.cc b/components/copresence/mediums/audio/audio_recorder_unittest.cc
index 1e01c94c92c7a3251d9a1cbd8cbbb3913a9bbec0..1d7c9590a3f379312e3a68d0e6d61238d14746e2 100644
--- a/components/copresence/mediums/audio/audio_recorder_unittest.cc
+++ b/components/copresence/mediums/audio/audio_recorder_unittest.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/memory/aligned_memory.h"
#include "base/run_loop.h"
+#include "components/copresence/mediums/audio/audio_recorder_impl.h"
#include "components/copresence/public/copresence_constants.h"
#include "components/copresence/test/audio_test_support.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -85,9 +86,9 @@ class AudioRecorderTest : public testing::Test {
void CreateSimpleRecorder() {
DeleteRecorder();
- recorder_ = new AudioRecorder(
+ recorder_ = new AudioRecorderImpl();
+ recorder_->Initialize(
base::Bind(&AudioRecorderTest::DecodeSamples, base::Unretained(this)));
- recorder_->Initialize();
}
void CreateRecorder(size_t channels,
@@ -108,12 +109,12 @@ class AudioRecorderTest : public testing::Test {
total_samples_ = samples;
- recorder_ = new AudioRecorder(
- base::Bind(&AudioRecorderTest::DecodeSamples, base::Unretained(this)));
+ recorder_ = new AudioRecorderImpl();
recorder_->set_input_stream_for_testing(
new TestAudioInputStream(params_, channel_data_, samples));
recorder_->set_params_for_testing(new media::AudioParameters(params_));
- recorder_->Initialize();
+ recorder_->Initialize(
+ base::Bind(&AudioRecorderTest::DecodeSamples, base::Unretained(this)));
}
void DeleteRecorder() {
@@ -181,7 +182,8 @@ class AudioRecorderTest : public testing::Test {
media::AudioParameters params_;
size_t total_samples_;
- AudioRecorder* recorder_;
+ // Deleted by calling Finalize() on the object.
+ AudioRecorderImpl* recorder_;
std::string received_samples_;
« no previous file with comments | « components/copresence/mediums/audio/audio_recorder_impl.cc ('k') | components/copresence/proto/enums.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698