Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1791)

Unified Diff: components/copresence/rpc/rpc_handler.cc

Issue 637223011: Redesign the copresence audio handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/rpc/rpc_handler.cc
diff --git a/components/copresence/rpc/rpc_handler.cc b/components/copresence/rpc/rpc_handler.cc
index 7c4d121f77444164bb3109dac558a1036747259b..485a14b218dd823db094117ecf9e290c8ce25f20 100644
--- a/components/copresence/rpc/rpc_handler.cc
+++ b/components/copresence/rpc/rpc_handler.cc
@@ -25,6 +25,7 @@
#include "components/copresence/proto/codes.pb.h"
#include "components/copresence/proto/data.pb.h"
#include "components/copresence/proto/rpcs.pb.h"
+#include "components/copresence/public/copresence_constants.h"
#include "components/copresence/public/copresence_delegate.h"
#include "net/http/http_status_code.h"
@@ -382,9 +383,10 @@ void RpcHandler::AddPlayingTokens(ReportRequest* request) {
if (!directive_handler_)
return;
- const std::string& audible_token = directive_handler_->CurrentAudibleToken();
+ const std::string& audible_token =
+ directive_handler_->CurrentAudioToken(AUDIBLE);
const std::string& inaudible_token =
- directive_handler_->CurrentInaudibleToken();
+ directive_handler_->CurrentAudioToken(INAUDIBLE);
if (!audible_token.empty())
AddTokenToRequest(request, AudioToken(audible_token, true));
@@ -477,12 +479,13 @@ void RpcHandler::SendHttpPost(net::URLRequestContextGetter* url_context_getter,
void RpcHandler::AudioDirectiveListToWhispernetConnector(
const std::string& token,
- bool audible,
+ AudioType type,
const WhispernetClient::SamplesCallback& samples_callback) {
+ DCHECK_LT(type, BOTH);
WhispernetClient* whispernet_client = delegate_->GetWhispernetClient();
if (whispernet_client) {
whispernet_client->RegisterSamplesCallback(samples_callback);
- whispernet_client->EncodeToken(token, audible);
+ whispernet_client->EncodeToken(token, type);
}
}

Powered by Google App Engine
This is Rietveld 408576698