Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: components/copresence/copresence_manager_impl.cc

Issue 637223011: Redesign the copresence audio handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/copresence_manager_impl.cc
diff --git a/components/copresence/copresence_manager_impl.cc b/components/copresence/copresence_manager_impl.cc
index 342ed1999a184cb59788612f951bb25175595bc7..6238c55a1edb4b434a55e5b4b641c5e5d8502a10 100644
--- a/components/copresence/copresence_manager_impl.cc
+++ b/components/copresence/copresence_manager_impl.cc
@@ -64,7 +64,9 @@ void CopresenceManagerImpl::CompleteInitialization() {
if (!init_failed_)
rpc_handler_->ConnectToWhispernet();
- for (PendingRequest& request : pending_requests_queue_) {
+ // for (PendingRequest& request : pending_requests_queue_) {
Daniel Erat 2014/10/17 22:25:59 delete this comment
Charlie 2014/10/17 22:42:25 ?
rkc 2014/10/18 00:21:54 Whoops, leftover from debugging. Done.
rkc 2014/10/18 00:21:54 Done.
Charlie 2014/10/18 00:44:11 Sorry, why can't we use the range-based version?
rkc 2014/10/18 00:51:30 Nothing, I had commented it out since I was debugg
+ for (size_t i = 0; i < pending_requests_queue_.size(); ++i) {
+ PendingRequest request = pending_requests_queue_[i];
if (init_failed_) {
request.callback.Run(FAIL);
} else {

Powered by Google App Engine
This is Rietveld 408576698