chrome/browser/extensions/api/copresence_private/copresence_private_api.cc - Issue 637223011: Redesign the copresence audio handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

Issue 637223011: Redesign the copresence audio handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_translations.cc ('k') | chrome/browser/resources/whispernet_proxy/js/init.js » ('j') | components/copresence/handlers/audio/audio_directive_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

diff --git a/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc b/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

index b9aed0de109a57e45ed16193604ed1b49fc4a4ea..c7f77622b85802bbcd7b41fb808aa9aebdc3ee50 100644

--- a/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

+++ b/chrome/browser/extensions/api/copresence_private/copresence_private_api.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/copresence/chrome_whispernet_client.h"

#include "chrome/browser/extensions/api/copresence/copresence_api.h"

#include "chrome/common/extensions/api/copresence_private.h"

+#include "components/copresence/public/copresence_constants.h"

#include "components/copresence/public/whispernet_client.h"

#include "media/base/audio_bus.h"

@@ -63,7 +64,9 @@ ExtensionFunction::ResponseAction CopresencePrivateSendSamplesFunction::Run() {

params->samples.size());

GetWhispernetClient()->GetSamplesCallback().Run(

- params->token.token, params->token.audible, samples);

+ params->token.token,

+ params->token.audible ? copresence::AUDIBLE : copresence::INAUDIBLE,

+ samples);

return RespondNow(NoArguments());

}