chrome/browser/extensions/api/copresence/copresence_translations.cc - Issue 637223011: Redesign the copresence audio handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/copresence/copresence_translations.cc

Issue 637223011: Redesign the copresence audio handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_api.h ('k') | chrome/browser/extensions/api/copresence_private/copresence_private_api.cc » ('j') | chrome/common/extensions/api/copresence_private.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/copresence/copresence_translations.cc

diff --git a/chrome/browser/extensions/api/copresence/copresence_translations.cc b/chrome/browser/extensions/api/copresence/copresence_translations.cc

index 5fecde278bb7058a09ce259fce0e0e4502cdcfce..4060c28e2c6321627028a6399450d80950c9be37 100644

--- a/chrome/browser/extensions/api/copresence/copresence_translations.cc

+++ b/chrome/browser/extensions/api/copresence/copresence_translations.cc

@@ -9,7 +9,7 @@

#include "components/copresence/proto/enums.pb.h"

#include "components/copresence/proto/rpcs.pb.h"

-using copresence::AUDIBLE;

+using copresence::AUDIBLE_AUDIO;

using copresence::AUDIO_CONFIGURATION_UNKNOWN;

using copresence::BROADCAST_AND_SCAN;

using copresence::BROADCAST_ONLY;

@@ -57,8 +57,8 @@ void SetTokenExchangeStrategy(const Strategy* strategy,

config == BROADCAST_SCAN_CONFIGURATION_UNKNOWN ?

default_config : config);

strategy_proto->set_audio_configuration(

- strategy->audible && *strategy->audible ?

- AUDIBLE : AUDIO_CONFIGURATION_UNKNOWN);

+ strategy->audible && *strategy->audible ? AUDIBLE_AUDIO

+ : AUDIO_CONFIGURATION_UNKNOWN);

} else {

strategy_proto->set_broadcast_scan_configuration(default_config);

strategy_proto->set_audio_configuration(AUDIO_CONFIGURATION_UNKNOWN);