Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: components/copresence/handlers/audio/audio_directive_list.h

Issue 637223011: Redesign the copresence audio handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_COPRESENCE_HANDLERS_AUDIO_AUDIO_DIRECTIVE_LIST_H_ 5 #ifndef COMPONENTS_COPRESENCE_HANDLERS_AUDIO_AUDIO_DIRECTIVE_LIST_H_
6 #define COMPONENTS_COPRESENCE_HANDLERS_AUDIO_AUDIO_DIRECTIVE_LIST_H_ 6 #define COMPONENTS_COPRESENCE_HANDLERS_AUDIO_AUDIO_DIRECTIVE_LIST_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
14 #include "base/time/time.h" 14 #include "base/time/time.h"
15 15
16 namespace base {
17 class TickClock;
18 }
19
16 namespace media { 20 namespace media {
17 class AudioBusRefCounted; 21 class AudioBusRefCounted;
18 } 22 }
19 23
20 namespace copresence { 24 namespace copresence {
21 25
22 struct AudioDirective { 26 struct AudioDirective final {
23 // Default ctor, required by the priority queue. 27 // Default ctor, required by the priority queue.
24 AudioDirective(); 28 AudioDirective();
25 AudioDirective(const std::string& op_id, base::Time end_time); 29 AudioDirective(const std::string& op_id, base::TimeTicks end_time);
26 30
27 std::string op_id; 31 std::string op_id;
28 base::Time end_time; 32 // We're currently using TimeTicks to track time. This may not work for cases
33 // where your machine suspends. See crbug.com/426136
34 base::TimeTicks end_time;
29 }; 35 };
30 36
31 // This class maintains a list of active audio directives. It fetches the audio 37 // This class maintains a list of active audio directives. It fetches the audio
32 // samples associated with a audio transmit directives and expires directives 38 // samples associated with a audio transmit directives and expires directives
33 // that have outlived their TTL. 39 // that have outlived their TTL.
34 // TODO(rkc): Once we implement more token technologies, move reusable code 40 // TODO(rkc): Once we implement more token technologies, move reusable code
35 // from here to a base class and inherit various XxxxDirectiveList 41 // from here to a base class and inherit various XxxxDirectiveList
36 // classes from it. 42 // classes from it.
37 class AudioDirectiveList { 43 class AudioDirectiveList {
38 public: 44 public:
39 AudioDirectiveList(); 45 AudioDirectiveList();
40 virtual ~AudioDirectiveList(); 46 ~AudioDirectiveList();
41 47
42 void AddDirective(const std::string& op_id, base::TimeDelta ttl); 48 void AddDirective(const std::string& op_id, base::TimeDelta ttl);
43 void RemoveDirective(const std::string& op_id); 49 void RemoveDirective(const std::string& op_id);
44 50
45 scoped_ptr<AudioDirective> GetActiveDirective(); 51 scoped_ptr<AudioDirective> GetActiveDirective();
46 52
47 private: 53 private:
48 // Comparator for comparing end_times on audio tokens. 54 // Comparator for comparing end_times on audio tokens.
49 class LatestFirstComparator { 55 class LatestFirstComparator {
50 public: 56 public:
51 // This will sort our queue with the 'latest' time being the top. 57 // This will sort our queue with the 'latest' time being the top.
52 bool operator()(const AudioDirective& left, 58 bool operator()(const AudioDirective& left,
53 const AudioDirective& right) const { 59 const AudioDirective& right) const {
54 return left.end_time < right.end_time; 60 return left.end_time < right.end_time;
55 } 61 }
56 }; 62 };
57 63
58 std::vector<AudioDirective>::iterator FindDirectiveByOpId( 64 std::vector<AudioDirective>::iterator FindDirectiveByOpId(
59 const std::string& op_id); 65 const std::string& op_id);
60 66
61 // This vector will be organized as a heap with the latest time as the first 67 // This vector will be organized as a heap with the latest time as the first
62 // element. Only currently active directives will exist in this list. 68 // element. Only currently active directives will exist in this list.
63 std::vector<AudioDirective> active_directives_; 69 std::vector<AudioDirective> active_directives_;
64 70
71 scoped_ptr<base::TickClock> clock_;
72
65 DISALLOW_COPY_AND_ASSIGN(AudioDirectiveList); 73 DISALLOW_COPY_AND_ASSIGN(AudioDirectiveList);
66 }; 74 };
67 75
68 } // namespace copresence 76 } // namespace copresence
69 77
70 #endif // COMPONENTS_COPRESENCE_HANDLERS_AUDIO_AUDIO_DIRECTIVE_LIST_H_ 78 #endif // COMPONENTS_COPRESENCE_HANDLERS_AUDIO_AUDIO_DIRECTIVE_LIST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698