Redesign the copresence audio handlers.

components/copresence/copresence_manager_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/copresence/copresence_manager_impl.h"
 
 #include "base/bind.h"
 #include "components/copresence/public/copresence_delegate.h"
 #include "components/copresence/public/whispernet_client.h"
 #include "components/copresence/rpc/rpc_handler.h"
@@ skipping 46 matching lines @@
 }
 
 void CopresenceManagerImpl::CompleteInitialization() {
   if (pending_init_operations_)
     return;
 
   DCHECK(rpc_handler_.get());
   if (!init_failed_)
     rpc_handler_->ConnectToWhispernet();
 
-  for (PendingRequest& request : pending_requests_queue_) {
+  //  for (PendingRequest& request : pending_requests_queue_) {

[Daniel Erat, 2014/10/17 22:25:59]

delete this comment

[Charlie, 2014/10/17 22:42:25]

?

[rkc, 2014/10/18 00:21:54]

Whoops, leftover from debugging.
Done.

[rkc, 2014/10/18 00:21:54]

Done.

[Charlie, 2014/10/18 00:44:11]

Sorry, why can't we use the range-based version?

[rkc, 2014/10/18 00:51:30]

Nothing, I had commented it out since I was debugging something and needed to
see the index :)
I put it back in place.

+  for (size_t i = 0; i < pending_requests_queue_.size(); ++i) {
+    PendingRequest request = pending_requests_queue_[i];
     if (init_failed_) {
       request.callback.Run(FAIL);
     } else {
       rpc_handler_->SendReportRequest(
           make_scoped_ptr(new copresence::ReportRequest(request.report)),
           request.app_id,
           request.callback);
     }
   }
   pending_requests_queue_.clear();
 }
 
 void CopresenceManagerImpl::InitStepComplete(
     const std::string& step, bool success) {
   if (!success) {
     LOG(ERROR) << step << " failed!";
     init_failed_ = true;
   }
 
   DVLOG(3) << "Init step: " << step << " complete.";
   pending_init_operations_--;
   CompleteInitialization();
 }
 
 }  // namespace copresence