Redesign the copresence audio handlers.

components/copresence/test/audio_test_support.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_COPRESENCE_COMMON_AUDIO_TEST_SUPPORT_
 #define COMPONENTS_COPRESENCE_COMMON_AUDIO_TEST_SUPPORT_
 
 #include <cstddef>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "components/copresence/mediums/audio/audio_player.h"
+#include "components/copresence/mediums/audio/audio_recorder.h"
 
 namespace media {
 class AudioBus;
 class AudioBusRefCounted;
 }
 
 namespace copresence {
 
 // Populate random samples given a random seed into the samples array.
 void PopulateSamples(int random_seed, size_t size, float* samples);
 
 // Create an audio bus populated with random samples.
 scoped_ptr<media::AudioBus> CreateRandomAudio(int random_seed,
                                               int channels,
                                               int samples);
 
 // Create an ref counted audio bus populated with random samples.
 scoped_refptr<media::AudioBusRefCounted>
     CreateRandomAudioRefCounted(int random_seed, int channels, int samples);
 
+class TestAudioPlayer : public AudioPlayer {

[Daniel Erat, 2014/10/21 19:43:22]

i think that names like AudioPlayerStub and AudioRecorderStub are more common
for classes like these. they should probably live alongside the implementation
in audio_player_stub/audio_recorder_stub classes, too.

[rkc, 2014/10/22 00:06:20]

Done.

+ public:
+  TestAudioPlayer();
+  virtual ~TestAudioPlayer();
+
+  // AudioPlayer overrides:
+  virtual void Initialize() override;
+  virtual void Play(
+      const scoped_refptr<media::AudioBusRefCounted>& samples) override;
+  virtual void Stop() override;
+  virtual void Finalize() override;
+  virtual bool IsPlaying() override;
+
+ private:
+  bool is_playing_;
+  DISALLOW_COPY_AND_ASSIGN(TestAudioPlayer);
+};
+
+class TestAudioRecorder : public AudioRecorderImpl {

[Daniel Erat, 2014/10/21 19:43:23]

why's this deriving from AudioRecorderImpl instead of AudioRecorder? use 'final'
there, maybe?

[rkc, 2014/10/22 00:06:20]

All derived classes marked final.
Done.

+ public:
+  TestAudioRecorder();
+  virtual ~TestAudioRecorder();
+
+  // AudioRecorder overrides:
+  virtual void Initialize(const RecordedSamplesCallback& cb) override;
+  virtual void Record() override;
+  virtual void Stop() override;
+  virtual void Finalize() override;
+  virtual bool IsRecording() override;
+
+  void TriggerDecodeRequest();
+
+ private:
+  RecordedSamplesCallback cb_;
+  bool is_recording_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestAudioRecorder);
+};
+
 }  // namespace copresence
 
 #endif  // COMPONENTS_COPRESENCE_COMMON_AUDIO_TEST_SUPPORT_