Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 637223005: Accessibility events should be sent to the axObjectCacheOwner's frame. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dglazkov
CC:
blink-reviews, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Accessibility events should be sent to the axObjectCacheOwner's frame. We started sending accessibility events to the frame client instead of the view client, to prepare for site isolation. However, a single AXObjectCache still spans all *local* frames, so accessibility events should be fired on the axObjectCacheOwner's frame, not on the event target's frame. BUG=424046 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dmazzoni
6 years, 2 months ago (2014-10-16 05:51:16 UTC) #2
Mike West
On 2014/10/16 05:51:16, dmazzoni wrote: LGTM.
6 years, 2 months ago (2014-10-16 05:58:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637223005/1
6 years, 2 months ago (2014-10-16 06:01:08 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 06:53:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183787

Powered by Google App Engine
This is Rietveld 408576698