More cleaning up in web_view.js.

More cleaning up in web_view.js.

I put all the public-facing API methods together, put them in alphabetical order, and made their location more obvious in the file. I also removed some more code/functions that were unused/unneeded.

Committed: https://crrev.com/ac1216a904719ebe0a7ba6ab3936571f6bd74caa
Cr-Commit-Position: refs/heads/master@{#299119}

[paulmeyer, 2014-10-09 19:58:23]

Patchset #1 (id:1) has been deleted

[paulmeyer, 2014-10-09 19:58:42]

paulmeyer@chromium.org changed reviewers:
+ lazyboy@chromium.org

[paulmeyer, 2014-10-09 19:58:43]

+lazyboy@

[fsamuel, 2014-10-09 20:11:16]

fsamuel@google.com changed reviewers:
+ fsamuel@google.com

[fsamuel, 2014-10-09 20:11:16]

I'll let Istiaque do the review but could you please be more descriptive about
what exactly is changing rather than simply saying we're doing more cleanup?
Thanks! :-)

[paulmeyer, 2014-10-09 20:16:27]

Okay, good idea. Done!

On 2014/10/09 20:11:16, fsamuel wrote:
> I'll let Istiaque do the review but could you please be more descriptive about
> what exactly is changing rather than simply saying we're doing more cleanup?
> Thanks! :-)

[lazyboy, 2014-10-09 20:27:20]

lgtm

Thanks for the updated description.

https://codereview.chromium.org/637193005/diff/30001/extensions/renderer/reso...
File extensions/renderer/resources/web_view.js (right):

https://codereview.chromium.org/637193005/diff/30001/extensions/renderer/reso...
extensions/renderer/resources/web_view.js:668: var webview_src = this.src;
nit: rename to webviewSrc

https://codereview.chromium.org/637193005/diff/30001/extensions/renderer/reso...
extensions/renderer/resources/web_view.js:721: var webview_src = this.src;
Same

[paulmeyer, 2014-10-09 20:38:18]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-10-09 20:39:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637193005/120001

[commit-bot: I haz the power, 2014-10-10 03:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 03:24:49]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[paulmeyer, 2014-10-10 12:33:30]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-10-10 12:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637193005/680001

[commit-bot: I haz the power, 2014-10-10 14:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 14:39:09]

Exceeded time limit waiting for builds to trigger.

[paulmeyer, 2014-10-10 14:39:31]

The CQ bit was checked by paulmeyer@chromium.org

[commit-bot: I haz the power, 2014-10-10 14:39:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637193005/680001

[commit-bot: I haz the power, 2014-10-10 15:35:54]

Committed patchset #3 (id:680001)

[commit-bot: I haz the power, 2014-10-10 15:36:51]

Patchset 3 (id:??) landed as
https://crrev.com/ac1216a904719ebe0a7ba6ab3936571f6bd74caa
Cr-Commit-Position: refs/heads/master@{#299119}