Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 637183002: Replace FINAL and OVERRIDE with their C++11 counterparts in content (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in content This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/7fc3ac7d5ac957a99031b20a8c54a197166b292a Cr-Commit-Position: refs/heads/master@{#298804}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -646 lines) Patch
M content/browser/bootstrap_sandbox_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.h View 2 chunks +16 lines, -16 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_runner.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_process_sub_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_thread_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/browser_url_handler_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/byte_stream.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/cert_store_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_impl.h View 1 chunk +20 lines, -20 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cocoa/system_hotkey_map_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/cross_site_transfer_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/browser/database_quota_client_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/database_tracker_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/device_monitor_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/device_monitor_udev.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/file_descriptor_info_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/histogram_internals_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/histogram_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/histogram_synchronizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/host_zoom_map_impl.h View 2 chunks +13 lines, -13 lines 0 comments Download
M content/browser/mach_broker_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/mach_broker_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/manifest/manifest_manager_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_internals_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/message_port_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/mime_registry_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/net_info_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/notification_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notification_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/pepper_flash_settings_helper_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/plugin_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/plugin_data_remover_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_loader_posix.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/plugin_loader_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_process_host.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_service_impl.h View 2 chunks +24 lines, -24 lines 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 7 chunks +23 lines, -23 lines 0 comments Download
M content/browser/power_monitor_message_broadcaster.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/power_monitor_message_broadcaster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/profiler_controller_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/profiler_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/push_messaging_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/quota_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resolve_proxy_msg_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_delegate_android.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_message_filter_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_handle.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_provider_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_registration_handle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_unregister_job.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 chunk +17 lines, -17 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.h View 2 chunks +16 lines, -16 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/signed_certificate_timestamp_store_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/site_instance_impl.h View 2 chunks +9 lines, -9 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/startup_task_runner_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/storage_partition_impl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/streams/stream_handle_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/streams/stream_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/streams/stream_url_request_job.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/streams/stream_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/system_message_window_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tcmalloc_internals_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/theme_helper_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/time_zone_monitor_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/time_zone_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/trace_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tracing/trace_uploader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/transition_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/udev_linux.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/utility_process_host_impl.h View 2 chunks +12 lines, -12 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/vibration/vibration_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/vibration/vibration_provider_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/webui/content_web_ui_controller_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/webui/generic_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/shared_resources_data_source.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/webui/web_ui_controller_factory_registry.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/webui/web_ui_data_source_impl.h View 1 chunk +14 lines, -14 lines 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/webui/web_ui_data_source_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/webui/web_ui_impl.h View 1 chunk +21 lines, -21 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac_fontloading_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac_system_access_unittest.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M content/public/browser/screen_orientation_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/app/shell_crash_reporter_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/shell/app/shell_main_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-08 05:51:38 UTC) #2
piman
lgtm
6 years, 2 months ago (2014-10-08 17:27:06 UTC) #3
MRV
On 2014/10/08 17:27:06, piman (Very slow to review) wrote: > lgtm Thanks mr. Piman for ...
6 years, 2 months ago (2014-10-08 17:30:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637183002/1
6 years, 2 months ago (2014-10-08 17:31:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/76668) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/22649) android_arm64_dbg_recipe ...
6 years, 2 months ago (2014-10-08 17:36:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637183002/1
6 years, 2 months ago (2014-10-09 02:05:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16499) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/20567)
6 years, 2 months ago (2014-10-09 03:09:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637183002/20001
6 years, 2 months ago (2014-10-09 04:09:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 07658fb22d7ea0c7d9f95407fef1e10c05f3a111
6 years, 2 months ago (2014-10-09 05:24:25 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 05:25:16 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7fc3ac7d5ac957a99031b20a8c54a197166b292a
Cr-Commit-Position: refs/heads/master@{#298804}

Powered by Google App Engine
This is Rietveld 408576698