Changes the location of the component resources in GN.

Changes the location of the component resources in GN.

BUG=401588
R=brettw@chromium.org, thestig@chromium.org, blundell@chromium.org
TEST=manually

Committed: https://crrev.com/fc01b28a3cad75c15b31b44443109cb9c69e629c
Cr-Commit-Position: refs/heads/master@{#299067}

[blundell, 2014-10-08 10:46:47]

What's the motivation for this change? I think that gyp and gn should generate
this stuff into the same directories, which it looks like was neither true
before this change nor after this change.

[Jun Mukai, 2014-10-08 17:39:34]

On 2014/10/08 10:46:47, blundell wrote:
> What's the motivation for this change? I think that gyp and gn should generate
> this stuff into the same directories, which it looks like was neither true
> before this change nor after this change.

GYP generates the header to gen/components/grit/components_resources.h (for
example) actually, and this CL changes the location there (without this, the
file is generated at gen/components/resources/grit/components_resources.h for
example).
This difference is big because of crbug.com/401588, generally we will like to
refer the generated resource headers as #include
"components/grit/components_resources.h" instead of direct
"grit/components_resources.h"

[brettw, 2014-10-08 18:05:39]

This looks right to me. LGTM

[Jun Mukai, 2014-10-09 02:17:02]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-09 02:25:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637163002/1

[commit-bot: I haz the power, 2014-10-09 03:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-09 03:13:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2014-10-09 04:19:36]

chrome/ lgtm

[Jun Mukai, 2014-10-09 05:12:10]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-09 05:13:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637163002/1

[commit-bot: I haz the power, 2014-10-09 05:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-09 05:22:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[blundell, 2014-10-09 05:31:16]

not lgtm

Sorry, I should have been more explicit. The resources change looks good; the
strings change doesn't.

https://codereview.chromium.org/637163002/diff/1/components/strings/BUILD.gn
File components/strings/BUILD.gn (right):

https://codereview.chromium.org/637163002/diff/1/components/strings/BUILD.gn#...
components/strings/BUILD.gn:67: output_dir = "$root_gen_dir/components"
gyp generates the strings into .../components/strings:

https://code.google.com/p/chromium/codesearch#chromium/src/components/compone...

[Jun Mukai, 2014-10-10 00:25:53]

On 2014/10/09 05:31:16, blundell wrote:
> not lgtm
> 
> Sorry, I should have been more explicit. The resources change looks good; the
> strings change doesn't.
> 
> https://codereview.chromium.org/637163002/diff/1/components/strings/BUILD.gn
> File components/strings/BUILD.gn (right):
> 
>
https://codereview.chromium.org/637163002/diff/1/components/strings/BUILD.gn#...
> components/strings/BUILD.gn:67: output_dir = "$root_gen_dir/components"
> gyp generates the strings into .../components/strings:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/components/compone...

Oops, sorry, I didn't notice that strings are generated into
components/strings/.
Reverted the strings part. PTAL.

[blundell, 2014-10-10 05:32:04]

lgtm

[Jun Mukai, 2014-10-10 05:44:54]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-10-10 05:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/637163002/20001

[commit-bot: I haz the power, 2014-10-10 06:27:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-10 06:28:15]

Patchset 2 (id:??) landed as
https://crrev.com/fc01b28a3cad75c15b31b44443109cb9c69e629c
Cr-Commit-Position: refs/heads/master@{#299067}