tools/perf/measurements/thread_times_unittest.py - Issue 637153002: telemetry: Remove command line args from page test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/thread_times_unittest.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/thread_times_unittest.py

diff --git a/tools/perf/measurements/thread_times_unittest.py b/tools/perf/measurements/thread_times_unittest.py

index ef544838617a4ca40b51f2310506f24206525863..44d7bd33221f3a10b36d2e1314dfac9653a4a0ae 100644

--- a/tools/perf/measurements/thread_times_unittest.py

+++ b/tools/perf/measurements/thread_times_unittest.py

@@ -46,8 +46,7 @@ class ThreadTimesUnitTest(page_test_test_case.PageTestTestCase):

def testWithSilkDetails(self):

ps = self.CreatePageSetFromFileInUnittestDataDir('scrollable_page.html')

- measurement = thread_times.ThreadTimes()

- self._options.report_silk_details = True

+ measurement = thread_times.ThreadTimes(report_silk_details=True)

results = self.RunMeasurement(measurement, ps, options = self._options)

self.assertEquals(0, len(results.failures))