Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: tools/perf/measurements/screenshot_unittest.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/screenshot_unittest.py
diff --git a/tools/perf/measurements/screenshot_unittest.py b/tools/perf/measurements/screenshot_unittest.py
index 379adbc57f82d5037d31dc5b864f3d386f6e00a9..b06f9c87d5201a73ad97fc7f2ca9ecac6fbf8b87 100644
--- a/tools/perf/measurements/screenshot_unittest.py
+++ b/tools/perf/measurements/screenshot_unittest.py
@@ -15,15 +15,15 @@ from telemetry.unittest_util import page_test_test_case
class ScreenshotUnitTest(page_test_test_case.PageTestTestCase):
def setUp(self):
self._options = options_for_unittests.GetCopy()
- self._options.png_outdir = tempfile.mkdtemp('_png_test')
+ self._png_outdir = tempfile.mkdtemp('_png_test')
def tearDown(self):
- shutil.rmtree(self._options.png_outdir)
+ shutil.rmtree(self._png_outdir)
@benchmark.Disabled('win') # http://crbug.com/386572
def testScreenshot(self):
ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html')
- measurement = screenshot.Screenshot()
+ measurement = screenshot.Screenshot(self._png_outdir)
results = self.RunMeasurement(measurement, ps, options=self._options)
if results.failures:
logging.warning(str(results.failures))

Powered by Google App Engine
This is Rietveld 408576698