Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/perf/measurements/record_per_area.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/record_per_area.py
diff --git a/tools/perf/measurements/record_per_area.py b/tools/perf/measurements/record_per_area.py
index 0804addd1e91476204405d29c3cc8af4603dbee3..cb89e1133f14855eebb079265de84798664036c8 100644
--- a/tools/perf/measurements/record_per_area.py
+++ b/tools/perf/measurements/record_per_area.py
@@ -10,14 +10,9 @@ from telemetry.value import scalar
class RecordPerArea(page_test.PageTest):
- def __init__(self):
+ def __init__(self, start_wait_time=2):
super(RecordPerArea, self).__init__('', True)
-
- def AddCommandLineArgs(self, parser):
- parser.add_option('--start-wait-time', type='float',
- default=2,
- help='Wait time before the benchmark is started '
- '(must be long enought to load all content)')
+ self._start_wait_time = start_wait_time
def CustomizeBrowserOptions(self, options):
smoothness.Smoothness.CustomizeBrowserOptions(options)
@@ -30,7 +25,7 @@ class RecordPerArea(page_test.PageTest):
def ValidateAndMeasurePage(self, page, tab, results):
# Wait until the page has loaded and come to a somewhat steady state.
# Needs to be adjusted for every device (~2 seconds for workstation).
- time.sleep(self.options.start_wait_time)
+ time.sleep(self._start_wait_time)
# Enqueue benchmark
tab.ExecuteJavaScript("""

Powered by Google App Engine
This is Rietveld 408576698