Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/perf/benchmarks/session_restore.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/session_restore.py
diff --git a/tools/perf/benchmarks/session_restore.py b/tools/perf/benchmarks/session_restore.py
index 3c95baee2586e43c74a6a4757bc6a4a6a5bbf91a..8fd991cae66605b16e294d27fdcf8f5967c4e3b4 100644
--- a/tools/perf/benchmarks/session_restore.py
+++ b/tools/perf/benchmarks/session_restore.py
@@ -40,20 +40,18 @@ class _SessionRestoreTest(benchmark.Benchmark):
@benchmark.Disabled('android', 'linux', 'reference')
class SessionRestoreColdTypical25(_SessionRestoreTest):
tag = 'cold'
- test = session_restore.SessionRestore
+ test = session_restore.SessionRestore(cold=True)
page_set = page_sets.Typical25PageSet
- options = {'cold': True,
- 'pageset_repeat': 5}
+ options = {'pageset_repeat': 5}
# crbug.com/325479, crbug.com/381990
@benchmark.Disabled('android', 'linux', 'reference')
class SessionRestoreWarmTypical25(_SessionRestoreTest):
tag = 'warm'
- test = session_restore.SessionRestore
+ test = session_restore.SessionRestore(cold=False)
page_set = page_sets.Typical25PageSet
- options = {'warm': True,
- 'pageset_repeat': 20}
+ options = {'pageset_repeat': 20}
# crbug.com/325479, crbug.com/381990, crbug.com/405386
@@ -61,10 +59,9 @@ class SessionRestoreWarmTypical25(_SessionRestoreTest):
class SessionRestoreWithUrlCold(_SessionRestoreTest):
"""Measure Chrome cold session restore with startup URLs."""
tag = 'cold'
- test = session_restore_with_url.SessionRestoreWithUrl
+ test = session_restore_with_url.SessionRestoreWithUrl(cold=True)
page_set = page_sets.StartupPagesPageSet
- options = {'cold': True,
- 'pageset_repeat': 5}
+ options = {'pageset_repeat': 5}
# crbug.com/325479, crbug.com/381990, crbug.com/405386
@@ -72,7 +69,6 @@ class SessionRestoreWithUrlCold(_SessionRestoreTest):
class SessionRestoreWithUrlWarm(_SessionRestoreTest):
"""Measure Chrome warm session restore with startup URLs."""
tag = 'warm'
- test = session_restore_with_url.SessionRestoreWithUrl
+ test = session_restore_with_url.SessionRestoreWithUrl(cold=False)
page_set = page_sets.StartupPagesPageSet
- options = {'warm': True,
- 'pageset_repeat': 10}
+ options = {'pageset_repeat': 10}

Powered by Google App Engine
This is Rietveld 408576698