Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: tools/telemetry/telemetry/benchmark_runner.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/benchmark_runner.py
diff --git a/tools/telemetry/telemetry/benchmark_runner.py b/tools/telemetry/telemetry/benchmark_runner.py
index b197392a9ce099bfd805c567c2bafa3c161f50dd..20d31c54af39ab2394b7fd8d04c605c172bb0979 100644
--- a/tools/telemetry/telemetry/benchmark_runner.py
+++ b/tools/telemetry/telemetry/benchmark_runner.py
@@ -23,7 +23,6 @@ from telemetry.core import environment
from telemetry.core import util
from telemetry.page import page_set
from telemetry.page import page_test
-from telemetry.page import profile_creator
from telemetry.util import find_dependencies
@@ -211,11 +210,6 @@ def _Tests():
for base_dir in config.base_paths:
tests += discover.DiscoverClasses(base_dir, base_dir, benchmark.Benchmark,
index_by_class_name=True).values()
nednguyen 2014/10/14 22:33:37 This change itself also deserves a separate patch.
ernstm 2014/10/16 22:32:13 Separate patch here: https://codereview.chromium.o
- page_tests = discover.DiscoverClasses(base_dir, base_dir,
- page_test.PageTest,
- index_by_class_name=True).values()
- tests += [test_class for test_class in page_tests
- if not issubclass(test_class, profile_creator.ProfileCreator)]
chrishenry 2014/10/15 18:26:09 So, are we sure that no bot is currently running r
ernstm 2014/10/16 22:32:13 Separate patch for removing run_measurement: https
return tests

Powered by Google App Engine
This is Rietveld 408576698