Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/perf/benchmarks/v8.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/benchmarks/repaint.py ('K') | « tools/perf/benchmarks/thread_times.py ('k') | tools/perf/measurements/page_cycler.py » ('j') | tools/perf/measurements/rasterize_and_record_micro.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 3b86416d1792e50b51d7c3e9a3f0c0f3b4cb682b..d70c208690e58c8dd36e897efa8e5dd23352a9a3 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -10,11 +10,8 @@ from telemetry import benchmark
@benchmark.Disabled # crbug.com/416502
class V8GarbageCollectionCases(benchmark.Benchmark):
"""Measure V8 metrics on the garbage collection cases."""
- test = timeline_based_measurement.TimelineBasedMeasurement
- page_set = page_sets.GarbageCollectionCasesPageSet
+ def CreatePageTest(self, options):
+ return timeline_based_measurement.TimelineBasedMeasurement(
nednguyen 2014/10/14 22:33:37 Add your #TODO back?
ernstm 2014/10/16 22:32:12 Done.
+ overhead_level='v8-overhead')
- # TODO(ernstm): Remove this argument when benchmark relevant v8 events become
- # available in the 'benchmark' category.
- @classmethod
- def SetArgumentDefaults(cls, parser):
- parser.set_defaults(overhead_level='v8-overhead')
+ page_set = page_sets.GarbageCollectionCasesPageSet
« tools/perf/benchmarks/repaint.py ('K') | « tools/perf/benchmarks/thread_times.py ('k') | tools/perf/measurements/page_cycler.py » ('j') | tools/perf/measurements/rasterize_and_record_micro.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698