Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: tools/perf/measurements/skpicture_printer.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import glob 4 import glob
5 import os 5 import os
6 6
7 from telemetry.page import page_test 7 from telemetry.page import page_test
8 from telemetry.value import scalar 8 from telemetry.value import scalar
9 9
10 10
11 _JS = 'chrome.gpuBenchmarking.printToSkPicture("{0}");' 11 _JS = 'chrome.gpuBenchmarking.printToSkPicture("{0}");'
12 12
13 13
14 class SkpicturePrinter(page_test.PageTest): 14 class SkpicturePrinter(page_test.PageTest):
15 @classmethod 15 def __init__(self, skp_outdir):
16 def AddCommandLineArgs(cls, parser): 16 super(SkpicturePrinter, self).__init__()
17 parser.add_option('-s', '--skp-outdir', 17 self._skp_outdir = skp_outdir
18 help='Output directory for the SKP files')
19
20 @classmethod
21 def ProcessCommandLineArgs(cls, parser, args):
22 if not args.skp_outdir:
23 parser.error('Please specify --skp-outdir')
24 cls._skp_outdir = args.skp_outdir
25 18
26 def CustomizeBrowserOptions(self, options): 19 def CustomizeBrowserOptions(self, options):
27 options.AppendExtraBrowserArgs(['--enable-gpu-benchmarking', 20 options.AppendExtraBrowserArgs(['--enable-gpu-benchmarking',
28 '--no-sandbox', 21 '--no-sandbox',
29 '--enable-deferred-image-decoding']) 22 '--enable-deferred-image-decoding'])
30 23
31 def ValidateAndMeasurePage(self, page, tab, results): 24 def ValidateAndMeasurePage(self, page, tab, results):
32 if tab.browser.platform.GetOSName() in ['android', 'chromeos']: 25 if tab.browser.platform.GetOSName() in ['android', 'chromeos']:
33 raise page_test.MeasurementFailure( 26 raise page_test.MeasurementFailure(
34 'SkPicture printing not supported on this platform') 27 'SkPicture printing not supported on this platform')
35 28
36 # Replace win32 path separator char '\' with '\\'. 29 # Replace win32 path separator char '\' with '\\'.
37 outpath = os.path.abspath( 30 outpath = os.path.abspath(
38 os.path.join(self._skp_outdir, page.file_safe_name)) 31 os.path.join(self._skp_outdir, page.file_safe_name))
39 js = _JS.format(outpath.replace('\\', '\\\\')) 32 js = _JS.format(outpath.replace('\\', '\\\\'))
40 tab.EvaluateJavaScript(js) 33 tab.EvaluateJavaScript(js)
41 pictures = glob.glob(os.path.join(outpath, '*.skp')) 34 pictures = glob.glob(os.path.join(outpath, '*.skp'))
42 results.AddValue(scalar.ScalarValue( 35 results.AddValue(scalar.ScalarValue(
43 results.current_page, 'saved_picture_count', 'count', len(pictures))) 36 results.current_page, 'saved_picture_count', 'count', len(pictures)))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698