Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: tools/perf/benchmarks/skpicture_printer.py

Issue 637153002: telemetry: Remove command line args from page test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress pylint E1003 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from measurements import skpicture_printer 5 from measurements import skpicture_printer
6 from telemetry import benchmark 6 from telemetry import benchmark
7 from telemetry.core import discover 7 from telemetry.core import discover
8 from telemetry.page import page_set 8 from telemetry.page import page_set
9 9
10 10
11 def _MatchPageSetName(page_set_name, page_set_base_dir): 11 def _MatchPageSetName(page_set_name, page_set_base_dir):
12 page_sets = [] 12 page_sets = []
13 page_sets += discover.DiscoverClasses(page_set_base_dir, page_set_base_dir, 13 page_sets += discover.DiscoverClasses(page_set_base_dir, page_set_base_dir,
14 page_set.PageSet, 14 page_set.PageSet,
15 index_by_class_name=True).values() 15 index_by_class_name=True).values()
16 for p in page_sets: 16 for p in page_sets:
17 if page_set_name == p.Name(): 17 if page_set_name == p.Name():
18 return p 18 return p
19 return None 19 return None
20 20
21 21
22 @benchmark.Disabled 22 @benchmark.Disabled
23 class SkpicturePrinter(benchmark.Benchmark): 23 class SkpicturePrinter(benchmark.Benchmark):
24 test = skpicture_printer.SkpicturePrinter 24 test = skpicture_printer.SkpicturePrinter
25 25
26 @classmethod 26 @classmethod
27 def AddTestCommandLineArgs(cls, parser): 27 def AddBenchmarkCommandLineArgs(cls, parser):
28 parser.add_option('--page-set-name', action='store', type='string') 28 parser.add_option('--page-set-name', action='store', type='string')
29 parser.add_option('--page-set-base-dir', action='store', type='string') 29 parser.add_option('--page-set-base-dir', action='store', type='string')
30 30
31 @classmethod 31 @classmethod
32 def ProcessCommandLineArgs(cls, parser, args): 32 def ProcessCommandLineArgs(cls, parser, args):
33 cls.PageTestClass().ProcessCommandLineArgs(parser, args) 33 cls.PageTestClass().ProcessCommandLineArgs(parser, args)
34 if not args.page_set_name: 34 if not args.page_set_name:
35 parser.error('Please specify --page-set-name') 35 parser.error('Please specify --page-set-name')
36 if not args.page_set_base_dir: 36 if not args.page_set_base_dir:
37 parser.error('Please specify --page-set-base-dir') 37 parser.error('Please specify --page-set-base-dir')
38 38
39 def CreatePageSet(self, options): 39 def CreatePageSet(self, options):
40 page_set_class = _MatchPageSetName(options.page_set_name, 40 page_set_class = _MatchPageSetName(options.page_set_name,
41 options.page_set_base_dir) 41 options.page_set_base_dir)
42 return page_set_class() 42 return page_set_class()
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698