Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 637103002: Increase WebTouchEvent::touchesLengthCap to 16. (Closed)

Created:
6 years, 2 months ago by mustaq
Modified:
6 years, 2 months ago
Reviewers:
Rick Byers, eseidel
CC:
blink-reviews, jamesr, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Increase WebTouchEvent::touchesLengthCap to 16. Pixel supports 16 touch-points but Blink caps the number at 12. This is change 2 of 3 on our way to update Blink's limit to 16. BUG=392959 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183546

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M public/web/WebInputEvent.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
mustaq
Will land this after http://crrev.com/639923002.
6 years, 2 months ago (2014-10-08 18:10:05 UTC) #2
Rick Byers
[Sorry for the delay - apparently I never hit publish when I reviewed this yesterday] ...
6 years, 2 months ago (2014-10-09 14:31:23 UTC) #3
mustaq
https://codereview.chromium.org/637103002/diff/1/public/web/WebInputEvent.h File public/web/WebInputEvent.h (right): https://codereview.chromium.org/637103002/diff/1/public/web/WebInputEvent.h#newcode488 public/web/WebInputEvent.h:488: // FIXME: Make this a variable that somehow depends ...
6 years, 2 months ago (2014-10-09 14:53:37 UTC) #4
mustaq
Need owner approval.
6 years, 2 months ago (2014-10-09 16:50:19 UTC) #6
eseidel
lgtm
6 years, 2 months ago (2014-10-10 16:36:52 UTC) #8
eseidel
Rick: you should consider making yourself a public/OWNER. Just email the existing owners for approval.
6 years, 2 months ago (2014-10-10 16:37:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637103002/20001
6 years, 2 months ago (2014-10-10 16:37:19 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 16:40:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183546

Powered by Google App Engine
This is Rietveld 408576698