Sets the default background color of inline signin and user manager to grey

content/public/browser/render_widget_host_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "content/common/content_export.h"
 #include "third_party/skia/include/core/SkBitmap.h"
+#include "third_party/skia/include/core/SkColor.h"
 #include "third_party/skia/include/core/SkRegion.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "ui/gfx/native_widget_types.h"
 
 class GURL;
 
 namespace gfx {
 class Rect;
 class Size;
 }
@@ skipping 79 matching lines @@
   virtual void SetShowingContextMenu(bool showing) = 0;
 
   // Returns the currently selected text.
   virtual base::string16 GetSelectedText() const = 0;
 
   // Subclasses should override this method to do what is appropriate to set
   // the background to be transparent or opaque.
   virtual void SetBackgroundOpaque(bool opaque) = 0;
   virtual bool GetBackgroundOpaque() = 0;
 
+  // Subclasses should override this method to set the initial background color.
+  virtual void SetBackgroundColor(SkColor color) = 0;

[sky, 2014/10/07 22:03:59]

Can SetBackgroundOpaque be removed if you add this?

[guohui, 2014/10/08 18:11:51]

Theoretically yes, you could replace SetBackgroundOpaque(false) with
SetBackgroundColor(0x00). However i prefer to keep both since all existing
callers of SetBakcgroundOpaque do not care about the color, also maybe in the
future we will support colored transparent background.

[guohui, 2014/10/08 18:22:33]

eh i forgot SkColor has an alpha component, so it could represent a transparent
color, then i do agree that it is cleaner to have only one method to set the
transparency. I ll fix it in a new patch.

Thanks!

+
   // Return value indicates whether the mouse is locked successfully or not.
   virtual bool LockMouse() = 0;
   virtual void UnlockMouse() = 0;
   // Returns true if the mouse pointer is currently locked.
   virtual bool IsMouseLocked() = 0;
 
   // Retrives the size of the viewport for the visible region. May be smaller
   // than the view size if a portion of the view is obstructed (e.g. by a
   // virtual keyboard).
   virtual gfx::Size GetVisibleViewportSize() const = 0;
@@ skipping 43 matching lines @@
   // Returns |true| if text is currently being spoken by Mac OS X.
   virtual bool IsSpeaking() const = 0;
   // Stops speaking, if it is currently in progress.
   virtual void StopSpeaking() = 0;
 #endif  // defined(OS_MACOSX)
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_WIDGET_HOST_VIEW_H_