Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html

Issue 637033003: [CSS Grid Layout] Fix positioned grid children position and size (Closed) Base URL:
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html b/LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html
similarity index 51%
copy from LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html
copy to LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html
index 2e7a26d8acf53ad9073c5a07f8ebcbdd32ceb68a..088ac943b3fa50520081ae3666dc5f3c35041274 100644
--- a/LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html
+++ b/LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html
@@ -6,7 +6,7 @@
display: grid;
grid-auto-flow: stack;
- embed {
+ .absolute {
position: absolute;
@@ -16,16 +16,19 @@
- <p>This test checks that adding a positioned block grid item after an inline grid item (which inserts it inside the
- existing anonymous block wrapping the inline item) does not crash on debug.</p>
+ <p>This tests checks that adding grid items when some of them are positioned does not crash.</p>
<div id="grid">
- test
+ <div></div>
+ <div class="absolute"></div>
var grid = document.getElementById("grid");
- var embed = document.createElement("embed");
- grid.appendChild(embed);
+ var newItem1 = document.createElement("div");
+ grid.appendChild(newItem1);
+ var newItem2 = document.createElement("div");
+ newItem2.className = "absolute";
+ grid.appendChild(newItem2);

Powered by Google App Engine
This is Rietveld 408576698