LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html - Issue 637033003: [CSS Grid Layout] Fix positioned grid children position and size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html

Issue 637033003: [CSS Grid Layout] Fix positioned grid children position and size (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update patch following review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/absolutely-positioned-grid-children-expected.txt ('k') | LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items-expected.txt » ('j') | Source/core/rendering/RenderBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html b/LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html

similarity index 51%

copy from LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html

copy to LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html

index 2e7a26d8acf53ad9073c5a07f8ebcbdd32ceb68a..088ac943b3fa50520081ae3666dc5f3c35041274 100644

--- a/LayoutTests/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item.html

+++ b/LayoutTests/fast/css-grid-layout/grid-add-item-with-positioned-items.html

@@ -6,7 +6,7 @@

display: grid;

grid-auto-flow: stack;

}

- embed {

+ .absolute {

position: absolute;

}

</style>

@@ -16,16 +16,19 @@

</script>

</head>

<body>

- <p>This test checks that adding a positioned block grid item after an inline grid item (which inserts it inside the

- existing anonymous block wrapping the inline item) does not crash on debug.</p>

+ <p>This tests checks that adding grid items when some of them are positioned does not crash.</p>

- test

+ <div></div>

+ <div class="absolute"></div>

</div>

var grid = document.getElementById("grid");

grid.offsetTop;

- var embed = document.createElement("embed");

- grid.appendChild(embed);

+ var newItem1 = document.createElement("div");

+ grid.appendChild(newItem1);

+ var newItem2 = document.createElement("div");

+ newItem2.className = "absolute";

+ grid.appendChild(newItem2);

</script>

</body>

</html>