Source/core/rendering/RenderGrid.h - Issue 637033003: [CSS Grid Layout] Fix positioned grid children position and size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.h

Issue 637033003: [CSS Grid Layout] Fix positioned grid children position and size (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove FIXME Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/absolutely-positioned-grid-children.html ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderGrid.h

diff --git a/Source/core/rendering/RenderGrid.h b/Source/core/rendering/RenderGrid.h

index cddb42315649507a9b19fc1e78c205724edb1647..a67fcb8009ed39e079b8bf33eb31ce1ca8af30e7 100644

--- a/Source/core/rendering/RenderGrid.h

+++ b/Source/core/rendering/RenderGrid.h

@@ -96,6 +96,9 @@ private:

GridTrackSizingDirection autoPlacementMinorAxisDirection() const;

void layoutGridItems();

+ void adjustPositionedGridItem(RenderBox*);

+ void layoutPositionedObjects(bool relayoutChildren, PositionedLayoutBehavior = DefaultLayout);

+ LayoutUnit offsetForAbsolutelyPositionedChild(const RenderBox&, GridTrackSizingDirection, LayoutUnit& breadth);

void populateGridPositions(const GridSizingData&);

typedef LayoutUnit (RenderGrid::* SizingFunction)(RenderBox&, GridTrackSizingDirection, Vector<GridTrack>&);