[CSS Grid Layout] Fix positioned grid children position and size

Source/core/rendering/RenderBox.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 165 matching lines @@
     FloatQuad absoluteContentQuad() const;
 
     // This returns the content area of the box (excluding padding and border). The only difference with contentBoxRect is that computedCSSContentBoxRect
     // does include the intrinsic padding in the content box as this is what some callers expect (like getComputedStyle).
     LayoutRect computedCSSContentBoxRect() const { return LayoutRect(borderLeft() + computedCSSPaddingLeft(), borderTop() + computedCSSPaddingTop(), clientWidth() - computedCSSPaddingLeft() - computedCSSPaddingRight(), clientHeight() - computedCSSPaddingTop() - computedCSSPaddingBottom()); }
 
     virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const override;
 
     // Use this with caution! No type checking is done!
     RenderBox* previousSiblingBox() const;
+    RenderBox* previousInFlowSiblingBox() const;
     RenderBox* nextSiblingBox() const;
+    RenderBox* nextInFlowSiblingBox() const;
     RenderBox* parentBox() const;
 
     bool canResize() const;
 
     // Visual and layout overflow are in the coordinate space of the box.  This means that they aren't purely physical directions.
     // For horizontal-tb and vertical-lr they will match physical directions, but for horizontal-bt and vertical-rl, the top/bottom and left/right
     // respectively are flipped when compared to their physical counterparts.  For example minX is on the left in vertical-lr,
     // but it is on the right in vertical-rl.
     LayoutRect noOverflowRect() const;
     LayoutRect layoutOverflowRect() const { return m_overflow ? m_overflow->layoutOverflowRect() : noOverflowRect(); }
@@ skipping 570 matching lines @@
     OwnPtr<RenderBoxRareData> m_rareData;
 };
 
 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderBox, isBox());
 
 inline RenderBox* RenderBox::previousSiblingBox() const
 {
     return toRenderBox(previousSibling());
 }
 
+inline RenderBox* RenderBox::previousInFlowSiblingBox() const
+{
+    RenderBox* previous;
+    for (previous = previousSiblingBox(); previous && previous->isOutOfFlowPositioned(); previous = previous->previousSiblingBox()) { }

[Julien - ping for review, 2014/11/24 21:44:40]

Nit: I prefer 2 lines to abide by Blink's 1 statement per line intent.

[Manuel Rego, 2014/12/01 11:10:37]

I've changed it for a while,
which probably makes it easer to understand.

+    return previous;
+}
+
 inline RenderBox* RenderBox::nextSiblingBox() const
 {
     return toRenderBox(nextSibling());
 }
 
+inline RenderBox* RenderBox::nextInFlowSiblingBox() const
+{
+    RenderBox* next;
+    for (next = nextSiblingBox(); next && next->isOutOfFlowPositioned(); next = next->nextSiblingBox()) { }

[Julien - ping for review, 2014/11/24 21:44:40]

Ditto.

[Manuel Rego, 2014/12/01 11:10:37]

Acknowledged.

+    return next;
+}
+
 inline RenderBox* RenderBox::parentBox() const
 {
     return toRenderBox(parent());
 }
 
 inline RenderBox* RenderBox::firstChildBox() const
 {
     return toRenderBox(slowFirstChild());
 }
 
@@ skipping 13 matching lines @@
         if (UNLIKELY(inlineBoxWrapper() != 0))
             deleteLineBoxWrapper();
     }
 
     ensureRareData().m_inlineBoxWrapper = boxWrapper;
 }
 
 } // namespace blink
 
 #endif // RenderBox_h