components/crash/tools/crash_service.cc - Issue 637023002: Misc. cleanup, primarily removing unused locals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/tools/crash_service.cc

Issue 637023002: Misc. cleanup, primarily removing unused locals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove macros.h change Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crash/tools/crash_service.cc

diff --git a/components/crash/tools/crash_service.cc b/components/crash/tools/crash_service.cc

index 48dcbc8b2dd0a5a0331f992373ebbef0dd5b7664..7e1798f9e6e0687a33805d46f186b94041d31dea 100644

--- a/components/crash/tools/crash_service.cc

+++ b/components/crash/tools/crash_service.cc

@@ -92,7 +92,7 @@ bool CreateTopWindow(HINSTANCE instance, bool visible) {

wcx.lpfnWndProc = CrashSvcWndProc;

wcx.hInstance = instance;

wcx.lpszClassName = L"crash_svc_class";

- ATOM atom = ::RegisterClassExW(&wcx);

+ ::RegisterClassExW(&wcx);

DWORD style = visible ? WS_POPUPWINDOW | WS_VISIBLE : WS_OVERLAPPED;

// The window size is zero but being a popup window still shows in the

@@ -466,7 +466,6 @@ PSECURITY_DESCRIPTOR CrashService::GetSecurityDescriptorForLowIntegrity() {

// Build the SDDL string for the label.

std::wstring sddl = L"S:(ML;;NW;;;S-1-16-4096)";

- DWORD error = ERROR_SUCCESS;

PSECURITY_DESCRIPTOR sec_desc = NULL;

PACL sacl = NULL;