Misc. cleanup, primarily removing unused locals.

chrome/app/chrome_crash_reporter_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_crash_reporter_client.h"
 
 #include "base/atomicops.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/files/file_path.h"
@@ skipping 198 matching lines @@
                     KEY_ALL_ACCESS) != ERROR_SUCCESS) {
     return;
   }
 
   // We use the current process id and the current tick count as a (hopefully)
   // unique combination for the crash dump value. There's a small chance that
   // across a reboot we might have a crash dump signal written, and the next
   // browser process might have the same process id and tick count, but crash
   // before consuming the signal (overwriting the signal with an identical one).
   // For now, we're willing to live with that risk.
-  int length = base::strings::SafeSPrintf(g_browser_crash_dump_prefix,
-                                          kBrowserCrashDumpPrefixTemplate,
-                                          chrome::kChromeVersion,
-                                          ::GetCurrentProcessId(),
-                                          ::GetTickCount());
-  if (length <= 0) {
+  if (base::strings::SafeSPrintf(g_browser_crash_dump_prefix,
+                                 kBrowserCrashDumpPrefixTemplate,
+                                 chrome::kChromeVersion,
+                                 ::GetCurrentProcessId(),
+                                 ::GetTickCount()) <= 0) {
     NOTREACHED();
     g_browser_crash_dump_prefix[0] = '\0';
     return;
   }
 
   // Hold the registry key in a global for update on crash dump.
   g_browser_crash_dump_regkey = regkey.Take();
 }
 
 void ChromeCrashReporterClient::RecordCrashDumpAttempt(bool is_real_crash) {
   // If we're not a browser (or the registry is unavailable to us for some
   // reason) then there's nothing to do.
   if (g_browser_crash_dump_regkey == NULL)
     return;
 
   // Generate the final value name we'll use (appends the crash number to the
   // base value name).
   const size_t kMaxValueSize = 2 * kBrowserCrashDumpPrefixLength;
   char value_name[kMaxValueSize + 1] = {};
-  int length = base::strings::SafeSPrintf(
-      value_name,
-      "%s-%x",
-      g_browser_crash_dump_prefix,
-      base::subtle::NoBarrier_AtomicIncrement(&g_browser_crash_dump_count, 1));
-
-  if (length > 0) {
+  if (base::strings::SafeSPrintf(
+          value_name, "%s-%x", g_browser_crash_dump_prefix,
+          base::subtle::NoBarrier_AtomicIncrement(&g_browser_crash_dump_count,
+                                                  1)) > 0) {
     DWORD value_dword = is_real_crash ? 1 : 0;
     ::RegSetValueExA(g_browser_crash_dump_regkey, value_name, 0, REG_DWORD,
                      reinterpret_cast<BYTE*>(&value_dword),
                      sizeof(value_dword));
   }
 }
 
 bool ChromeCrashReporterClient::ReportingIsEnforcedByPolicy(
     bool* breakpad_enabled) {
 // Determine whether configuration management allows loading the crash reporter.
@@ skipping 112 matching lines @@
 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return process_type == switches::kRendererProcess ||
          process_type == switches::kPluginProcess ||
          process_type == switches::kPpapiPluginProcess ||
          process_type == switches::kZygoteProcess ||
          process_type == switches::kGpuProcess;
 }
 
 }  // namespace chrome