Source/core/rendering/style/StyleRareNonInheritedData.h - Issue 636993002: [CSS Grid Layout] Upgrade justify-content parsing to CSS3 Box Alignment spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/StyleRareNonInheritedData.h

Issue 636993002: [CSS Grid Layout] Upgrade justify-content parsing to CSS3 Box Alignment spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/resolver/StyleBuilderCustom.cpp ('K') | « Source/core/rendering/style/RenderStyleConstants.h ('k') | Source/core/rendering/style/StyleRareNonInheritedData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/style/StyleRareNonInheritedData.h

diff --git a/Source/core/rendering/style/StyleRareNonInheritedData.h b/Source/core/rendering/style/StyleRareNonInheritedData.h

index ed8bd710b926adc8c587085a38d900dbe74c4272..6a44a27ea023c1d5c394de58803c14a1b115cf98 100644

--- a/Source/core/rendering/style/StyleRareNonInheritedData.h

+++ b/Source/core/rendering/style/StyleRareNonInheritedData.h

@@ -159,7 +159,9 @@ public:

unsigned m_alignItemsOverflowAlignment : 2; // OverflowAlignment

unsigned m_alignSelf : 4; // ItemPosition

unsigned m_alignSelfOverflowAlignment : 2; // OverflowAlignment

- unsigned m_justifyContent : 3; // EJustifyContent

Julien - ping for review 2014/10/20 21:24:02 Shouldn't we remove EJustifyContent?

jfernandez 2014/10/27 11:44:37 Acknowledged.

+ unsigned m_justifyContent : 4; // ContentPosition

+ unsigned m_justifyContentDistribution : 3; // ContentDistributionType

+ unsigned m_justifyContentOverflowAlignment : 2; // OverflowAlignment

unsigned userDrag : 2; // EUserDrag

unsigned textOverflow : 1; // Whether or not lines that spill out should be truncated with "..."