Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 636953002: [turbofan] Fix HashCode/Equals for floating point operators. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix HashCode/Equals for floating point operators. Those floating point constant operators require bitwise handling of their parameters, otherwise 0.0 equals -0.0. This is solved in a general way by adding new base::bit_equal_to and base::bit_hash function objects. TEST=unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24450

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Patch Set 3 : Address offline comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -19 lines) Patch
M src/base/functional.h View 1 2 4 chunks +71 lines, -8 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M test/unittests/base/functional-unittest.cc View 1 2 2 chunks +67 lines, -0 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 1 chunk +75 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-07 14:18:11 UTC) #1
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-08 05:54:27 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/636953002/diff/20001/src/base/functional.h File src/base/functional.h (right): https://codereview.chromium.org/636953002/diff/20001/src/base/functional.h#newcode71 src/base/functional.h:71: return hash_combine(hash_combine(vs...), hash<T>()(v)); Reordered because we pass the seed ...
6 years, 2 months ago (2014-10-08 05:56:34 UTC) #5
Sven Panne
lgtm
6 years, 2 months ago (2014-10-08 06:53:47 UTC) #6
Benedikt Meurer
6 years, 2 months ago (2014-10-08 07:32:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698