Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tests/toolchain/nacl.scons

Issue 636933004: stop building/testing old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebase master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/tls_segment_x86_32/nacl.scons ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/toolchain/nacl.scons
diff --git a/tests/toolchain/nacl.scons b/tests/toolchain/nacl.scons
index 97dcc9fbddff973832ee684e0f6fe73b5ce127b4..c5b370f082fbfae9c5efbdcb6f7e5b692c84a916 100644
--- a/tests/toolchain/nacl.scons
+++ b/tests/toolchain/nacl.scons
@@ -46,13 +46,7 @@ node = env.CommandValidatorTestNacl('whole_archive_test.out',
image=nexe)
env.AddNodeToTestSuite(node,
['toolchain_tests', 'small_tests'],
- 'run_whole_archive_test',
- # The old ncval doesn't like the new linker's style
- # of padding the code segment. TODO(mcgrathr):
- # Remove this is_broken= when we the old ncval is no
- # longer ever built and used for this test.
- is_broken=(env.Bit('target_x86') and
- not env.Bit('validator_ragel')))
+ 'run_whole_archive_test')
def AddIntrinsicTest(test_env, src, exit_status,
« no previous file with comments | « tests/tls_segment_x86_32/nacl.scons ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698