Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: src/trusted/service_runtime/build.scons

Issue 636933004: stop building/testing old x86 validator. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: rebase master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/service_runtime/build.scons
diff --git a/src/trusted/service_runtime/build.scons b/src/trusted/service_runtime/build.scons
index bb9bab9f8d78e0587a76eaf704b3716cfb426b60..879f51adec91d4d2b150e4077c4a5fbf842473c9 100644
--- a/src/trusted/service_runtime/build.scons
+++ b/src/trusted/service_runtime/build.scons
@@ -777,21 +777,6 @@ node = env.CommandSelLdrTestNacl(
sel_ldr_flags=['-F'])
env.AddNodeToTestSuite(node, ['small_tests'], 'run_fuzz_nullptr_test')
-# Test hello_world binary with obsolete, non-ragel based validator.
-if (not env.Bit('validator_ragel') and env.Bit('target_x86')
- and env.Bit('nacl_static_link')):
- node = env.CommandSelLdrTestNacl(
- 'dfa_hwd.out',
- hello_world_nexe,
- stdout_golden = env.File('testdata/hello_world.stdout'),
- stderr_golden = env.File('testdata/non_dfa_validator_hello.stderr'),
- filter_regex = '"^(Hello, World!)$' + '|' +
- '^[[][^]]*[]] (USING OBSOLETE NON-DFA-BASED VALIDATOR!)$"',
- filter_group_only = 'true',
- )
- env.AddNodeToTestSuite(node, ['medium_tests', 'validator_tests'],
- 'run_dfa_validator_hello_world_test')
-
if env.Bit('target_mips32'):
text_region_start = 0x00020000
# Use arbitrary non-page-aligned addresses for data and rodata.

Powered by Google App Engine
This is Rietveld 408576698