Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 636913002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/testing (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/testing This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M Source/core/testing/GCObservation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalProfilers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/testing/LayerRect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/LayerRectList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/MockPagePopupDriver.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/testing/MockPagePopupDriver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/NullExecutionContext.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/testing/NullExecutionContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/testing/TypeConversions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 13:14:45 UTC) #2
MRV
PTAL
6 years, 2 months ago (2014-10-07 13:15:10 UTC) #3
Mike West
rs lgtm.
6 years, 2 months ago (2014-10-07 13:22:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636913002/1
6 years, 2 months ago (2014-10-07 13:26:56 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:17:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183336

Powered by Google App Engine
This is Rietveld 408576698