|
|
[turbofan] Drop broken StaticParameterTraits.
The StaticParameterTraits are broken by design, and cause way too much
trouble. The compilers usually pick the wrong specialization (i.e. the
default specialization is picked for Load and Phi even tho there is a
specialization for MachineType), which is not only the reason why GVN is
ineffective and slow, but can also lead to correctness issues in some
rare cases.
Also clean up some minor bugs/inconsistencies on the way.
TEST=cctest,unittests
R=svenpanne@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=24437
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+490 lines, -417 lines) |
Patch |
 |
M |
src/assembler.h
|
View
|
|
2 chunks |
+7 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/assembler.cc
|
View
|
|
2 chunks |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/compiler/common-operator.h
|
View
|
|
3 chunks |
+47 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/compiler/common-operator.cc
|
View
|
|
5 chunks |
+45 lines, -73 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-graph.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-graph.cc
|
View
|
|
4 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-operator.h
|
View
|
|
5 chunks |
+35 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-operator.cc
|
View
|
|
3 chunks |
+105 lines, -35 lines |
0 comments
|
Download
|
|
M |
src/compiler/machine-operator.h
|
View
|
|
2 chunks |
+8 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/compiler/machine-operator.cc
|
View
|
|
2 chunks |
+17 lines, -31 lines |
0 comments
|
Download
|
|
M |
src/compiler/node.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
src/compiler/node-matchers.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
src/compiler/operator.h
|
View
|
|
4 chunks |
+44 lines, -119 lines |
0 comments
|
Download
|
|
M |
src/compiler/operator.cc
|
View
|
|
2 chunks |
+33 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/compiler/raw-machine-assembler.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/compiler/simplified-operator.h
|
View
|
1
2
|
3 chunks |
+10 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/compiler/simplified-operator.cc
|
View
|
|
6 chunks |
+16 lines, -40 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime.h
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime.cc
|
View
|
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
src/unique.h
|
View
|
1
|
3 chunks |
+13 lines, -1 line |
0 comments
|
Download
|
|
M |
src/utils.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/utils.cc
|
View
|
|
2 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
test/cctest/compiler/codegen-tester.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
test/cctest/compiler/simplified-graph-builder.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
test/cctest/compiler/test-codegen-deopt.cc
|
View
|
|
3 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
test/cctest/compiler/test-js-typed-lowering.cc
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
test/cctest/compiler/test-operator.cc
|
View
|
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
test/cctest/compiler/test-scheduler.cc
|
View
|
|
5 chunks |
+20 lines, -15 lines |
0 comments
|
Download
|
|
M |
test/unittests/compiler/graph-unittest.cc
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|
Chromium Code Reviews
Issue
636893002:
[turbofan] Drop broken StaticParameterTraits. (Closed)
