Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: content/public/browser/speech_recognition_session_context.h

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes threading issues Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/speech_recognition_session_context.h
diff --git a/content/public/browser/speech_recognition_session_context.h b/content/public/browser/speech_recognition_session_context.h
index 532a4e47e6533c899452e7d5406862dcff397dc3..7ae18bcde76b29558ab3f4fb5a1f208ab4775915 100644
--- a/content/public/browser/speech_recognition_session_context.h
+++ b/content/public/browser/speech_recognition_session_context.h
@@ -25,25 +25,24 @@ struct CONTENT_EXPORT SpeechRecognitionSessionContext {
~SpeechRecognitionSessionContext();
int render_process_id;
- int render_view_id;
int render_frame_id;
- // Browser plugin guest's render view id, if this context represents a speech
+ // Browser plugin guest's render frame id, if this context represents a speech
// recognition request from an embedder on behalf of the guest. This is used
// for input tag where speech bubble is to be shown.
//
// TODO(lazyboy): Right now showing bubble from guest does not work, we fall
// back to embedder instead, fix this and use
- // embedder_render_process_id/embedder_render_view_id similar to Web Speech
+ // embedder_render_process_id/embedder_render_frame_id similar to Web Speech
// API below.
- int guest_render_view_id;
+ int guest_render_frame_id;
- // The pair (|embedder_render_process_id|, |embedder_render_view_id|)
+ // The pair (|embedder_render_process_id|, |embedder_render_frame_id|)
// represents a Browser plugin guest's embedder. This is filled in if the
// session is from a guest Web Speech API. We use these to check if the
// embedder (app) is permitted to use audio.
int embedder_render_process_id;
- int embedder_render_view_id;
+ int embedder_render_frame_id;
int request_id;

Powered by Google App Engine
This is Rietveld 408576698