content/common/frame_messages.h - Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes threading issues Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/speech/speech_recognition_dispatcher_host.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/speech_recognition_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 1552af5967104719a3bb550a55ada9aa3e6121ea..6eb272fe852beaffe526246df96aada1c5633224 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -181,11 +181,11 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,

// The routing_id of the render view associated with the navigation.

// We need to track the RenderViewHost routing_id because of downstream

// dependencies (crbug.com/392171 DownloadRequestHandle, SaveFileManager,

- // ResourceDispatcherHostImpl, MediaStreamUIProxy,

- // SpeechRecognitionDispatcherHost and possibly others). They look up the view

- // based on the ID stored in the resource requests. Once those dependencies

- // are unwound or moved to RenderFrameHost (crbug.com/304341) we can move the

- // client to be based on the routing_id of the RenderFrameHost.

+ // ResourceDispatcherHostImpl, MediaStreamUIProxy, and possibly others). They

+ // look up the view based on the ID stored in the resource requests. Once

+ // those dependencies are unwound or moved to RenderFrameHost

+ // (crbug.com/304341) we can move the client to be based on the routing_id of

+ // the RenderFrameHost.

IPC_STRUCT_MEMBER(int, render_view_routing_id)

IPC_STRUCT_END()