Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: content/browser/loader/resource_scheduler_filter.cc

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes threading issues Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_scheduler_filter.cc
diff --git a/content/browser/loader/resource_scheduler_filter.cc b/content/browser/loader/resource_scheduler_filter.cc
index b9f240d4fc1f3ca2e3586df8567000e97ec46f6e..62a08f40dd15cde8de5eeb944255ea6db9051c5a 100644
--- a/content/browser/loader/resource_scheduler_filter.cc
+++ b/content/browser/loader/resource_scheduler_filter.cc
@@ -47,12 +47,11 @@ bool ResourceSchedulerFilter::OnMessageReceived(const IPC::Message& message) {
!params.was_within_same_page) {
// We need to track the RenderViewHost routing_id because of downstream
// dependencies (crbug.com/392171 DownloadRequestHandle,
- // SaveFileManager, ResourceDispatcherHostImpl, MediaStreamUIProxy,
- // SpeechRecognitionDispatcherHost and possibly others). They look up
- // the view based on the ID stored in the resource requests.
- // Once those dependencies are unwound or moved to RenderFrameHost
- // (crbug.com/304341) we can move the client to be based on the
- // routing_id of the RenderFrameHost.
+ // SaveFileManager, ResourceDispatcherHostImpl, MediaStreamUIProxy, and
+ // possibly others). They look up the view based on the ID stored in the
+ // resource requests. Once those dependencies are unwound or moved to
+ // RenderFrameHost (crbug.com/304341) we can move the client to be based
+ // on the routing_id of the RenderFrameHost.
scheduler->OnNavigate(child_id_, params.render_view_routing_id);
}
break;

Powered by Google App Engine
This is Rietveld 408576698