Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/speech/chrome_speech_recognition_manager_delegate.h

Issue 636863003: Make SpeechRecognition per RenderFrame instead of per RenderView. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes threading issues Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
diff --git a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
index b806b9979f88cdc7a18636eac5b6415fac9c2bba..4272c8a08e0b7b3198fd21ec767e8ae91afcfde6 100644
--- a/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
+++ b/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
@@ -11,6 +11,10 @@
#include "content/public/browser/speech_recognition_manager_delegate.h"
#include "content/public/browser/speech_recognition_session_config.h"
+namespace content {
+class WebContents;
+} // namespace content
+
namespace speech {
// This is Chrome's implementation of the SpeechRecognitionManagerDelegate
@@ -51,7 +55,7 @@ class ChromeSpeechRecognitionManagerDelegate
bool FilterProfanities(int render_process_id) override;
// Callback called by |tab_watcher_| on the IO thread to signal tab closure.
Charlie Reis 2014/12/01 23:49:43 This is called on the UI thread and not the IO thr
mlamouri (slow - plz ping) 2014/12/08 17:41:04 Correct. Fixed.
- virtual void TabClosedCallback(int render_process_id, int render_view_id);
+ virtual void TabClosedCallback(content::WebContents* web_contents);
private:
class OptionalRequestInfo;
@@ -61,8 +65,7 @@ class ChromeSpeechRecognitionManagerDelegate
// the result in the IO thread through |callback|.
static void CheckRenderViewType(
base::Callback<void(bool ask_user, bool is_allowed)> callback,
- int render_process_id,
- int render_view_id);
+ const content::SpeechRecognitionSessionContext& context);
scoped_refptr<OptionalRequestInfo> optional_request_info_;
scoped_refptr<TabWatcher> tab_watcher_;

Powered by Google App Engine
This is Rietveld 408576698